support tls connection #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small js fix
Fix ts
|
New feature finished. No more commits |
manyuanrong
reviewed
Jan 12, 2021
src/client.ts
Outdated
| @@ -21,10 +21,20 @@ export class MongoClient { | |||
| if (typeof options === "string") { | |||
| options = parse(options); | |||
| } | |||
| const conn = await Deno.connect({ | |||
| var conn; | |||
There was a problem hiding this comment.
Do not use any at will. Don't use var
Clean code
Fix Deno fmt
Small fix
|
The new feature is ok, and the new url parser is much more generic and powerful. I finish my commits. You can Merge If you want. |
|
Also has minor fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.