-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ssl param #335
Feature/ssl param #335
Conversation
A couple other things I noticed by didn't touch:
|
@justinmchase Thank you Justin for making this PR
It's welcome to fix all of these issues, if your expected behaviors are a part of MongoDB standard driver specifications
yes, really not a good design, PR is welcome :-) |
My bad, I thought I re-ran the test but apparently I didn't. I fixed it now but some other test is not succeeding. Locally its passing and in 3/4 versions of ubuntu it seems to be passing. I'm not sure what to do about it. It seems unrelated to this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Justin. That's awesome
@lucsoft |
I mean it's fixes the issue but we need to refactor the parser lmao But this is not a scope for this PR |
Thanks everyone. |
When you create an Azure cosmos db it gives you a connection string like this:
However when you try to use this connection string to actually connect it basically hangs indefinitely. After some debugging I figured out that the connection string parsing is simply not handling the
ssl=true
parameter. Simply settingtls = true
in this case allows deno_mongo to successfully connect to azure cosmosdb.