-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add geospatial type support #349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you rebase aka fix the merge conflicts from master |
…eojson (sync main)
OK, I've just done it |
erfanium
requested changes
Apr 19, 2022
erfanium
approved these changes
Apr 19, 2022
@Jaysok Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will add geospatial type support. Thus resolves #341
External Dependency
Added external dependency from @types/geojson which already defined geojson types pretty good, conforming rfc7946 - GeoJSON Format.
Tests
I focused mainly on making a geospatial query easily and make simple GeoJSON queries work with newly added types.
Test data is mostly from MongoDB official documents and I picked some from there.
GeoJSON query objects in the actual queries are picked from the data or made by myself.
Place
Neighborhoods
IPosition
- made by myselfPossible issues in the future
$geoNear
is not considered.