Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add helper method dropDatabase #363

Merged
merged 2 commits into from
Jul 21, 2022
Merged

add helper method dropDatabase #363

merged 2 commits into from
Jul 21, 2022

Conversation

Jaysok
Copy link
Contributor

@Jaysok Jaysok commented Jul 20, 2022

No description provided.

@Jaysok Jaysok requested a review from erfanium as a code owner July 20, 2022 23:36
@Jaysok Jaysok closed this Jul 20, 2022
@erfanium
Copy link
Member

@Jaysok Why you close it?

@erfanium
Copy link
Member

I see CI is failing for a strange reason. but I don'k think there's something wrong with your code

@erfanium
Copy link
Member

CI it's now okay, you can reopen this PR

@Jaysok
Copy link
Contributor Author

Jaysok commented Jul 21, 2022

Oh thanks, just after PR I found CI is failing.

I don't have enough time to review the code at that time, so I simply closed it.

thanks anyway. :)

@Jaysok Jaysok reopened this Jul 21, 2022
@lucsoft lucsoft self-requested a review July 21, 2022 06:44
lucsoft
lucsoft approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@lucsoft lucsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Even some Tests!

erfanium
erfanium approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@erfanium erfanium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@erfanium erfanium merged commit f5b1c0a into denodrivers:main Jul 21, 2022
@Jaysok Jaysok mentioned this pull request Jul 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucsoft lucsoft lucsoft approved these changes

@erfanium erfanium erfanium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jaysok @erfanium @lucsoft