IndexOptionsConflict for chunk collection - pr #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erfanium
requested changes
Aug 10, 2022
tests/cases/06_gridfs.ts
Outdated
Comment on lines
35
to
49
| chunkSizeBytes: 255 * 8, | ||
| }); | ||
|
|
||
| await (await fetch("https://deno.land/images/deno_logo.png")).body!.pipeTo( | ||
| upstream, | ||
| ); | ||
| await (await fetch("https://deno.land/images/artwork/snow_den.png")).body! | ||
| .pipeTo( | ||
| upstream, | ||
| ); | ||
|
|
||
| const getId = | ||
| (await bucket.find({ filename: "deno_logo.png" }).toArray())[0]._id; | ||
|
|
||
| const expected = await fetch("https://deno.land/images/deno_logo.png"); | ||
| const expected = await fetch("https://deno.land/images/artwork/snow_den.png"); | ||
| const actual = await new Response(await bucket.openDownloadStream(getId)) | ||
| .arrayBuffer(); | ||
|
|
There was a problem hiding this comment.
Please revert these changes, because we already localized these assets so this PR has merge conflicts
lucsoft
requested changes
Aug 10, 2022
tests/cases/06_gridfs.ts
Outdated
| await writer.close(); | ||
| }; | ||
| await addAsset(0); | ||
| await addAsset(1); |
There was a problem hiding this comment.
Where is the assert in this code? Shouldn’t the test case somehow check if the indexes where skipped?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#364