refactor(op_crate/fetch): align streams to spec (#9103)

Fixes #8814
denoland · Jan 14, 2021 · b8303c7 · b8303c7
1 parent 2d12085
commit b8303c7
Show file tree

Hide file tree

Showing 13 changed files with 3,373 additions and 3,826 deletions.
diff --git a/cli/tests/unit/fetch_test.ts b/cli/tests/unit/fetch_test.ts
@@ -1047,9 +1047,13 @@ unitTest(
     const buf = bufferServer(addr);
     const stream = new TransformStream();
     const writer = stream.writable.getWriter();
-    await writer.write(new TextEncoder().encode("hello "));
-    await writer.write(new TextEncoder().encode("world"));
-    await writer.close();
+    // transformer writes don't resolve until they are read, so awaiting these
+    // will cause the transformer to hang, as the suspend the transformer, it
+    // is also illogical to await for the reads, as that is the whole point of
+    // streams is to have a "queue" which gets drained...
+    writer.write(new TextEncoder().encode("hello "));
+    writer.write(new TextEncoder().encode("world"));
+    writer.close();
     const response = await fetch(`http://${addr}/blah`, {
       method: "POST",
       headers: [

diff --git a/cli/tests/unit/streams_internal_test.ts b/cli/tests/unit/streams_internal_test.ts
diff --git a/cli/tests/unit/streams_piping_test.ts b/cli/tests/unit/streams_piping_test.ts