-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port tools/http_server.py to Rust, merge with hyper_hello #1453
Comments
@ry Hi :) I would like to try this issue. So I have a question. How should I run |
Hi! I see it's been over a year since the last comment, I would like to take this as my first issue if no one else is working on this :) |
Hey @hermesespinola I was supposed to work on that, but if you want to give it a try then go ahead! This issue is quite complex and I'd suggest tackling it in a few steps: The very first PR should consist only of a) and b) - integration with |
@bartlomieju I would like to give it a try, thanks for the advice, I'll reach to you if I have any questions. |
@hermesespinola What's the status on this? If you're not working on it I'd like to give it a try |
@humancalico AFAIK no one is working on this problem and I planned to work on it this week. Reach me out on Discord if you want to discuss details. |
Hi @humancalico, sorry I've been working on other stuff since then, please, take it! |
Done in #6364 |
Be forewarned: This issue is seemingly relatively easy, but it will likely take a great deal of work to make it green. I'd roughly estimate it would be 2 days of work for myself.
Many of our tests depend on a local http server running on localhost:4545 .. this server is currently implemented in python
https://github.com/denoland/deno/blob/e809673cecef8383d4b3e873de260b35182d2ef9/tools/http_server.py
We would like to reduce our dependencies on python over time, and we already have all the infrastructure available to implement this in Rust using Hyper.
The text was updated successfully, but these errors were encountered: