chore: move redirect test server to rust #6364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
force-pushed
the
rust_http_test_server
branch
from
8dcfa78 to
0aa77d7
Compare
bartlomieju
reviewed
Jun 23, 2020
ry
force-pushed
the
rust_http_test_server
branch
from
6752a57 to
4ecf10a
Compare
ry
force-pushed
the
rust_http_test_server
branch
from
f18e9a6 to
47d117c
Compare
failures:
std_tests
type_directives_redirect
x_deno_warning
|
@ry I'm giving up on fixing the benchmarks - I have no idea what is happening here and why (it seems that) every benchmark starts a dozen servers. I'm no longer surprised that CI is red anyway, this is a mess. Feel free of course to roll back all the non-fixes I've pushed. |
piscisaureus
force-pushed
the
rust_http_test_server
branch
from
0b1649c to
08d4175
Compare
bartlomieju
reviewed
Jul 4, 2020
| [[package]] | ||
| name = "tokio-rustls" | ||
| version = "0.13.1" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "15cb62a0d2770787abc96e99c1cd98fcf17f94959f3af63ca85bdfb203f051b4" | ||
| dependencies = [ | ||
| "futures-core", | ||
| "rustls", | ||
| "rustls 0.17.0", |
There was a problem hiding this comment.
I think it means we got two different versions of tokio-rustls and rustls
There was a problem hiding this comment.
Yeah I found that weird too but there does not seem to be an easy workaround.
IIRC (from last night) reqwest requires the latest version of tokio-rustls, and warp is a little behind in updating it's dependencies...
Comment on lines
+419
to
+420
| self.test_server.kill().expect("failed to kill test_server"); | ||
| let _ = self.test_server.wait(); |
piscisaureus
reviewed
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.