Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno publish panics "source text should be in the cache if snippet source is a specifier" #22288

Closed
littledivy opened this issue Feb 6, 2024 · 3 comments · Fixed by #22310
Closed

deno publish panics "source text should be in the cache if snippet source is a specifier" #22288

littledivy opened this issue Feb 6, 2024 · 3 comments · Fixed by #22310
Assignees
@dsherret
Labels
bug Something isn't working correctly cli related to cli/ dir

Comments

@littledivy
Copy link
Member

littledivy commented Feb 6, 2024 •
edited
Loading 

Checking fast check type graph for errors...
error[invalid-external-import]: invalid import to a non-JSR 'https' specifier

============================================================
Deno has panicked. This is a bug in Deno. Please report this
at https://github.com/denoland/deno/issues/new.
If you can reliably reproduce this panic, include the
reproduction steps and re-run with the RUST_BACKTRACE=1 env
var set and include the backtrace in your report.

Platform: macos aarch64
Version: 1.40.3
Args: ["deno", "publish", "--dry-run"]

thread 'main' panicked at cli/diagnostics.rs:200:44:
source text should be in the cache if snippet source is a specifier
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

To reproduce:

git clone https://github.com/littledivy/duckdb && cd duckdb
touch deno.json

deno publish --dry-run
@littledivy littledivy added bug Something isn't working correctly cli related to cli/ dir labels Feb 6, 2024
@dsherret dsherret self-assigned this Feb 6, 2024
@dsherret dsherret mentioned this issue Feb 6, 2024
Merged
@dsherret
Copy link
Member

dsherret commented Feb 6, 2024

@littledivy can you try again in canary? It might be fixed.

@dsherret dsherret mentioned this issue Feb 6, 2024
Merged
@dsherret
Copy link
Member

dsherret commented Feb 6, 2024

Nevermind, it will be fixed in #22310

dsherret added a commit that referenced this issue Feb 7, 2024
@dsherret
fix(publish): handle diagnostic outside graph (#22310)
e546848 
Hacky quick fix. The real fix is a lot more work to do (move the
`SourceTextInfo` into all the diagnostics in order to make this less
error pone). I've already started on it, but it will require a lot of
downstream create changes.

Closes #22288
@littledivy
Copy link
Member Author

Fixed in canary now. Thanks

littledivy pushed a commit that referenced this issue Feb 8, 2024
@dsherret @littledivy
fix(publish): handle diagnostic outside graph (#22310)
2ad7e70 
Hacky quick fix. The real fix is a lot more work to do (move the
`SourceTextInfo` into all the diagnostics in order to make this less
error pone). I've already started on it, but it will require a lot of
downstream create changes.

Closes #22288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsherret dsherret

Labels
bug Something isn't working correctly cli related to cli/ dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(publish): handle diagnostic outside graph dsherret/deno
2 participants
@dsherret @littledivy