Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readRequest in go does not take a Conn as an argument #2383

Closed
ry opened this issue May 21, 2019 · 1 comment
Closed

readRequest in go does not take a Conn as an argument #2383

ry opened this issue May 21, 2019 · 1 comment

Comments

@ry
Copy link
Member

ry commented May 21, 2019

https://github.com/golang/go/blob/1d1ba85d9986bb56226046c06dec4ce63ef9fe48/src/net/http/request.go#L992

The corresponding code in http/server.ts should be changed to also not depend on conn.
https://github.com/denoland/deno_std/blob/aad0896346805513dc87eb01cd867a1513f574b1/http/server.ts#L201-L220

@ry
Copy link
Member Author

ry commented May 21, 2019

moved denoland/std#427

@ry ry closed this as completed May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant