Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readRequest in go does not take a Conn as an argument #427

Closed
ry opened this issue May 21, 2019 · 0 comments · Fixed by #430
Closed

readRequest in go does not take a Conn as an argument #427

ry opened this issue May 21, 2019 · 0 comments · Fixed by #430

Comments

@ry
Copy link
Member

ry commented May 21, 2019

https://github.com/golang/go/blob/1d1ba85d9986bb56226046c06dec4ce63ef9fe48/src/net/http/request.go#L992

The corresponding code in http/server.ts should be changed to also not depend on conn.
https://github.com/denoland/deno_std/blob/aad0896346805513dc87eb01cd867a1513f574b1/http/server.ts#L201-L220
This was referenced May 21, 2019
Closed
Merged
@zekth zekth mentioned this issue May 22, 2019
Merged
@ry ry closed this as completed in #430 May 22, 2019
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this issue Oct 24, 2024
@iuioiua
feat: <ItemsList /> with cursor-based pagination (denoland#445)
853e6e6 
This change contains a few changes that affect interdependent features.
Changes include:
- Add `<ItemsList />` with cursor-based pagination
- Remove now unused code for the previous pagination solution
- Fix and rework voting functionality relating to denoland#427
- Tweak REST API endpoints return signature to be more generic, using a
`values` field
- `fetchValues()`
- Simplify and optimise `<VoteButton />`
- New `DELETE/GET /api/items/[id]/vote` endpoint
- New `GET /api/me/votes` endpoint
- Other various cleanups

Note: The migration script has been tested successfully locally.

Closes denoland#427
Closes denoland#414
Towards denoland#439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[http] delete conn parameter in readRequest
1 participant
@ry