Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno compile - Warning for dangling symlink in embedded files #27023

Closed
dsherret opened this issue Nov 23, 2024 · 0 comments · Fixed by #27296
Closed

Deno compile - Warning for dangling symlink in embedded files #27023

dsherret opened this issue Nov 23, 2024 · 0 comments · Fixed by #27296
Labels
compile related to the `deno compile` feature suggestion suggestions for new features (yet to be agreed)

Comments

@dsherret
Copy link
Member

dsherret commented Nov 23, 2024

There's probably not much reason for someone to include a symlink in the vfs that doesn't point to a valid file system entry in the embedded executable. We should probably warn in this case.

I'm not sure we should always include the file because it might be something the user doesn't want to include or they might also be forgetting to include other files. The warning should help them make the right choice or ignore.

@dsherret dsherret added suggestion suggestions for new features (yet to be agreed) compile related to the `deno compile` feature labels Nov 23, 2024
@dsherret dsherret changed the title Deno compile - Warning for dangling symlink Deno compile - Warning for dangling symlink in embedded files Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compile related to the `deno compile` feature suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant