fix(compile): analyze modules in directory specified in --include #27296
Conversation
cli/standalone/virtual_fs.rs
Outdated
| } | ||
| VfsFileSubDataKind::ModuleGraph => { | ||
| virtual_file.module_graph_offset = offset; | ||
| virtual_file.module_graph_offset = offset_and_len; |
There was a problem hiding this comment.
A test case I added surfaced a bug where we weren't storing the length of module graph only files meaning a file could be corrupted.
|
Not sure why windows is failing. Going to work on outputting the contents of the vfs and that might help. |
| @@ -1,5 +1,4 @@ | |||
| Compile file:///[WILDCARD]/node_modules_symlink_outside/main.ts to [WILDCARD] | |||
| Warning Symlink target is outside '[WILDCARD]node_modules_symlink_outside'. Inlining symlink at '[WILDCARD]node_modules_symlink_outside[WILDCARD]node_modules[WILDCARD]test.txt' to '[WILDCARD]target.txt' as file. | |||
There was a problem hiding this comment.
The root of the VFS is determined after everything is inside it, so this is now represented properly inside it.
| @@ -3,8 +3,13 @@ Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz | |||
| Initialize @denotest/esm-basic@1.0.0 | |||
| Check file:///[WILDCARD]/node_modules_symlink_outside/main.ts | |||
| Compile file:///[WILDCARD]/node_modules_symlink_outside/main.ts to [WILDLINE] | |||
| Warning Symlink target is outside '[WILDLINE]node_modules_symlink_outside'. Excluding symlink at '[WILDLINE]node_modules_symlink_outside[WILDLINE]node_modules[WILDLINE]symlink_dir' with target '[WILDLINE]some_folder'. | |||
There was a problem hiding this comment.
Same here. The root of the VFS is determined after everything is inside it, so this is now represented properly inside it.
| .chars() | ||
| .take(40) | ||
| .map(|c| c.len_utf8()) | ||
| .sum::<usize>(); |
There was a problem hiding this comment.
Bug in the wildcard code.
| @@ -66,6 +66,9 @@ | |||
| "tempDir": { | |||
| "type": "boolean" | |||
| }, | |||
| "symlinkedTempDir": { | |||
| "type": "boolean" | |||
| }, | |||
There was a problem hiding this comment.
Already existed, but was missing in this schema.json file.
| @@ -1,3 +1,2 @@ | |||
| Deno.mkdirSync("data"); | |||
There was a problem hiding this comment.
Didn't do anything. Must have been leftover from something else.
| .iter(), | ||
| ), | ||
| ); | ||
| log::debug!("Binary root dir: {}", root_dir_url); |
There was a problem hiding this comment.
We now figure out the root after populating the VFS. This makes it much more reliable.
| /// The root of the system above any drive letters. | ||
| WindowSystemRoot, | ||
| Path(PathBuf), | ||
| } |
There was a problem hiding this comment.
This allows having a VFS that spans drive letters on windows.
cli/standalone/binary.rs
Outdated
| panic!( | ||
| "Unhandled scenario where a duplicate entry was found: {:?}", | ||
| existing | ||
| ); | ||
| } |
There was a problem hiding this comment.
Could this be an error instead of a panic?
There was a problem hiding this comment.
I think it's better to panic instead of error because this would be a bug in Deno.
Working on this surfaced some bugs in the VFS implementation. I ended up changing the file system implementation to determine its root directory as the last step of building it instead of being the first step which makes it much more reliable.
Closes #26941
Closes #27023 (makes it obsolete)