Disabling deno-ts(80006)

[harrysolovay]

I often see this diagnostic in functions that return a promise:

deno-ts(80006)

I believe this is a mistake / should be something end developers can disable.

For instance, the following JS is valid:

function completeText(messages: string[]): Promise<string> {
  return chat.completions.create({ messages }).then(unwrapChoice)
}

However, I still see the diagnostic. And it suggests the following refactor:

function completeText(messages: string[]): Promise<string> {
  const completion = await chat.completions.create({ messages })
  return unwrapChoice(completion)
}

I prefer the initial version. Can I / how might I get the Deno LS to stop including this diagnostic?

[dsherret]

Do you have a reproduction? It shouldn't error for the first one.

[harrysolovay]

Yes: the source code can be found here.

[dsherret]

Ah, I didn't realize this was just a suggestion from TypeScript. I think we just need a way to disable or filter out certain typescript suggestions (related https://stackoverflow.com/a/77265400/188246). Thoughts, @nayeemrmn?

[nayeemrmn]

Seems like an upstream issue. Is there a way of disabling it with ts server that doesn't work here?

[nayeemrmn]

#27373 will implement "typescript.suggestionActions.enabled": false which is TypeScript's recommended solution to this: microsoft/vscode#61326 (comment). It seems to work pretty well, but a more granular setting is requested upstream at microsoft/TypeScript#28825. That doesn't exist yet.