Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): respect "typescript.suggestionActions.enabled" setting #27373

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix(lsp): respect "typescript.suggestionActions.enabled" setting #27373

merged 2 commits into from
Dec 16, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Closes #27353.

@nayeemrmn nayeemrmn mentioned this pull request Dec 16, 2024
Closed
@dsherret dsherret changed the title feat(lsp): respect "typescript.suggestionActions.enabled" setting fix(lsp): respect "typescript.suggestionActions.enabled" setting Dec 16, 2024
dsherret
dsherret approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's categorize as a fix to land in LTS.

@nayeemrmn nayeemrmn merged commit 358bf56 into denoland:main Dec 16, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-suggestion-actions-setting branch December 16, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabling deno-ts(80006)
2 participants
@nayeemrmn @dsherret