Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd behavior when using a function called "define" and checkJs together #4110

Closed
ry opened this issue Feb 24, 2020 · 2 comments
Closed

Odd behavior when using a function called "define" and checkJs together #4110

ry opened this issue Feb 24, 2020 · 2 comments
Labels
bug Something isn't working correctly

Comments

@ry
Copy link
Member

ry commented Feb 24, 2020

@seishun reports:

tsconfig.json

{
  "compilerOptions": {
    "checkJs": true,
    "allowJs": true
  }
}

foo.ts

import "./test.js";

test.js

function define(foo) {}
define(["long"]);

..\deno\target\debug\deno.exe --config tsconfig.json foo.ts

Compile file:///C:/Users/Nikolai/test-proj-delete/foo.ts
error: Uncaught URIError: relative import path "long" not prefixed with / or ./ or ../ Imported from "file:///C:/Users/Nikolai/test-proj-delete/test.js"

Ref #4040 #4010
cc @kitsonk

@ry ry added the bug Something isn't working correctly label Feb 24, 2020
@kitsonk
Copy link
Contributor

kitsonk commented Feb 24, 2020

Yeah, there are a few things that I need to work through to get everything right.

@bartlomieju
Copy link
Member

Works fine on v1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants