Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote CDN imports not being properly resolved #4117

Closed
FredKSchott opened this issue Feb 25, 2020 · 2 comments · Fixed by #4120
Closed

remote CDN imports not being properly resolved #4117

FredKSchott opened this issue Feb 25, 2020 · 2 comments · Fixed by #4120

Comments

@FredKSchott
Copy link

Originally reported here: gcanti/fp-ts#1130
Confirmed regression locally, working on v0.33.0 but broken on v0.34.0
Can't seem to import anything from the Pika CDN due to this.

For context, every package (ex: https://cdn.pika.dev/fp-ts@^2.4.4) will always import from another file by /* path.

$ cat test.ts
import * as ns from 'https://cdn.pika.dev/fp-ts@^2.4.4';
console.log(ns);

$ deno --reload test.ts
Compile file:///test/test.ts
Download https://cdn.pika.dev/fp-ts@^2.4.4

error TS2307: Cannot find module '/-/fp-ts@v2.5.1-bEgPQP5yi6MRzC5XlNqk/dist=es2019/fp-ts.js'.
► http://localhost:3005/fp-ts@^2.4.4:23:15
23 export * from '/-/fp-ts@v2.5.1-bEgPQP5yi6MRzC5XlNqk/dist=es2019/fp-ts.js';
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error TS2307: Cannot find module '/-/fp-ts@v2.5.1-bEgPQP5yi6MRzC5XlNqk/dist=es2019/fp-ts.js'.
► http://localhost:3005/fp-ts@^2.4.4:24:23
24 export {default} from '/-/fp-ts@v2.5.1-bEgPQP5yi6MRzC5XlNqk/dist=es2019/fp-ts.js';
                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 2 errors.
@kitsonk
Copy link
Contributor

kitsonk commented Feb 25, 2020

Hrmmmm... yeah, it was all in the same domain space of trying to "improve" import detection problems on some modules (ref: #4040 #4010 #4110 #4078)

The use cases help, just need to figure out how to make everyone happy.

@FredKSchott
Copy link
Author

👍 sounds like you're on top of it. Let me know if I can help in any way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants