Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unstable native plugins #10908

Merged
merged 7 commits into from
Jul 2, 2021
Merged

Remove unstable native plugins #10908

merged 7 commits into from
Jul 2, 2021

Conversation

bartlomieju
Copy link
Member

Closes #8490

@wperron
Copy link
Contributor

wperron commented Jun 9, 2021

Seems like a substantial change (even if the API was under the unstable flag) I think we should include it in the upcoming 1.12 release instead of the next patch release for 1.11

@rracariu
Copy link

rracariu commented Jun 9, 2021

Is there any replacement in the works/planed?

@ry ry added this to the 1.12.0 milestone Jun 9, 2021
@eliassjogreen eliassjogreen mentioned this pull request Jun 12, 2021
Open
@eliassjogreen
Copy link
Contributor

Would a pr adding classic C ffi support (dlopen, dlsym, dlerror, dlclose) be welcome or should i wait for deno 2.0? Removing plugin support also removes the possibility to do native calls which is a thing which can be very useful for everything from webview support, native windowing for WebGPU, fast cpu optimized code and lots of other cool things. I think removing plugins would put deno at a disadvantage in many use cases to node and the napi.

@bartlomieju bartlomieju mentioned this pull request Jun 25, 2021
Closed
@crowlKats crowlKats mentioned this pull request Jun 27, 2021
Closed
@bartlomieju bartlomieju mentioned this pull request Jun 27, 2021
Merged
@bartlomieju
Copy link
Member Author

Is there any replacement in the works/planed?

Yes, FFI API proposed in #11152

@bartlomieju bartlomieju requested a review from ry June 30, 2021 02:21
ry
ry requested changes Jun 30, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss with @piscisaureus

@eliassjogreen eliassjogreen mentioned this pull request Jun 30, 2021
Closed
@bartlomieju bartlomieju mentioned this pull request Jul 1, 2021
Closed
ry
ry approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We will land FFI soon after.

@bartlomieju bartlomieju merged commit 7dd4090 into denoland:main Jul 2, 2021
@bartlomieju bartlomieju deleted the remove_native_plugins branch July 2, 2021 14:11
ry added a commit to ry/deno that referenced this pull request Jul 11, 2021
@ry
Revert "Remove unstable native plugins (denoland#10908)"
b350c03 
This reverts commit 7dd4090.
ry added a commit that referenced this pull request Jul 12, 2021
@ry
Revert "Remove unstable native plugins (#10908)"
511c48a 
This reverts commit 7dd4090.
@sant123 sant123 mentioned this pull request Aug 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wperron wperron wperron approved these changes

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Remove unstable native plugins
5 participants
@bartlomieju @wperron @rracariu @eliassjogreen @ry