Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update wpt #12206

Merged
merged 6 commits into from
Sep 25, 2021
Merged

chore: update wpt #12206

merged 6 commits into from
Sep 25, 2021

Conversation

andreubotella
Copy link
Contributor

This PR also removes tests that were deleted or moved, and enables a number of WPT tests that were not listed in the expectations.

This PR does not enable the myriad of worker tests outside of the workers directory. That will be left to a follow-up PR.

Andreu Botella added 4 commits September 24, 2021 11:42
- The reftype tentative tests in `wasm/jsapi/table`
  (`constructor-reftypes.tentative.any.html`, `grow-reftypes.tentative.any.html`
  and `set-reftypes.tentative.any.html`) were merged with the main tests
  `constructor.any.html`, `grow.any.html` and `get-set.any.html` in
  web-platform-tests/wpt#30805.
- `WebCryptoAPI/encrypt_decrypt/rsa.https.any.html` doesn't seem to have ever
  existed as a test, so it's hard to explain why it was listed as one.
- `WebCryptoAPI/generateKey/successes_RSA-OAEP.https.any.html` was listed
  both without a query string parameter, and with one for each variant.
- `WebCryptoAPI/randomUUID.any.html` was renamed to
  `WebCryptoAPI/randomUUID.https.any.js` in web-platform-tests/wpt#28967.
- The `WebIDL` directory was renamed to the lowercase `webidl` in
  web-platform-tests/wpt#30327.
Some of these tests were added to the WPT repo at some point in the past
without being reflected on our expectations file. This change also
enables some of the fetch non-API tests and some of the HTML scripting
tests which might be relevant to Deno.

This commit does not enable the myriad of worker tests outside of the
`workers` directory. That will be left to a follow-up PR.
@@ -13598,6 +13649,190 @@
"<a> and <area>.searchParams should be undefined"
],
"idlharness.any.html": true,
"toascii.window.html": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are never going to pass (they use DOM elements). We should remove them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the tests use the <a> and <area> elements, but others use the URL class.

@andreubotella
Copy link
Contributor Author

/websockets/stream/tentative/abort.any.html?wpt_flags=h2 seems to be flaky, so I've opened #12208 to track that and I'll be removing it from the expectations.

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@lucacasonato lucacasonato merged commit 1380def into denoland:main Sep 25, 2021
@andreubotella andreubotella deleted the update-wpt branch September 25, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants