Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat: Add "deno jupyter" subcommand #13122

Closed
wants to merge 92 commits into from
Closed

[WIP] feat: Add "deno jupyter" subcommand #13122

wants to merge 92 commits into from

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Dec 17, 2021 •
edited
Loading

Closes #13016

TODO:

  • Add support for DEBUG env variable
  • Make stdio out less flaky (don't use channel for all messages)
  • Investigate BrokenPipe errors we're getting and how we could improve that situation (Codec Error: Broken Pipe zeromq/zmq.rs#153)

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bartlomieju bartlomieju mentioned this pull request Dec 18, 2021
Merged
bnoordhuis
bnoordhuis reviewed Dec 18, 2021
View reviewed changes
cli/tools/jupyter.rs Outdated Show resolved Hide resolved
cli/tools/jupyter.rs Outdated Show resolved Hide resolved
cli/tools/jupyter.rs Outdated Show resolved Hide resolved
cli/tools/jupyter.rs Outdated Show resolved Hide resolved
cli/tools/jupyter.rs Outdated Show resolved Hide resolved
cli/tools/jupyter.rs Outdated Show resolved Hide resolved
cli/tools/jupyter.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju commented Dec 18, 2021
View reviewed changes
cli/tools/jupyter.rs Outdated Show resolved Hide resolved
@apowers313
Copy link
Contributor

Trying to do this all in a single file is becoming cumbersome. Can we create a cli/jupyter folder and start creating multiple files there?

@bartlomieju
Copy link
Member Author

Trying to do this all in a single file is becoming cumbersome. Can we create a cli/jupyter folder and start creating multiple files there?

Yes, that sounds good to me

bartlomieju pushed a commit that referenced this pull request Jan 5, 2022
@AaronO @bartlomieju
cleanup(cli): use op Extensions (#13223)
4a1ab26 
Enabling op-middleware for overrides in lieu of imperative .replace_op() etc...

Impacts #13219,  #12938, #13122
@dsherret dsherret marked this pull request as draft March 18, 2022 22:34
@stale
Copy link

stale bot commented Jun 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 10, 2022
@bartlomieju bartlomieju removed the stale label Jun 12, 2022
@bartlomieju
Copy link
Member Author

Note to self: try https://github.com/cetra3/tmq

@fdionisi fdionisi mentioned this pull request Jul 13, 2022
Closed
@stale
Copy link

stale bot commented Sep 20, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 20, 2022
@stale stale bot closed this Sep 27, 2022
This was referenced Aug 30, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apowers313 apowers313 apowers313 left review comments

@bnoordhuis bnoordhuis bnoordhuis left review comments

@ry ry ry left review comments

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First class Jupyter notebook integration
5 participants
@bartlomieju @CLAassistant @apowers313 @ry @bnoordhuis