feat(ext/webstorage): IndexedDB #14035
Conversation
crowlKats
requested review from
bartlomieju,
lucacasonato and
littledivy
as code owners
|
|
||
| const request = webidl.createBranded(IDBOpenDBRequest); | ||
|
|
||
| (async () => { |
There was a problem hiding this comment.
Perhaps my JS-fu is lacking but what's the point of this async IIFE? It's created, invoked, try-catched and finishes immediately, there is no await point so at least I cannot see anything to this except maybe strack trace differences here?
| const value = webidl.converters.BufferSource(input); | ||
| return { | ||
| type: "binary", | ||
| value: value.slice(), |
There was a problem hiding this comment.
Use primordial. EDIT: Oops looks like its not ready yet. Mark as draft maybe?
There was a problem hiding this comment.
Mark as draft maybe?
One of the TODOs in the original comment says "complete impl" 🙃
| keys.find((item) => compareTwoKeys(item, key)) === undefined | ||
| ) { | ||
| keys.push(key); |
| } | ||
| // TODO: complete implementation | ||
| } else if (ArrayIsArray(key)) { | ||
| return key.every(isValidKeyPath); |
| const identifiers = keyPath.split("."); | ||
| assert(identifiers.length !== 0); | ||
| identifiers.pop(); |
There was a problem hiding this comment.
I am not doing primordials yet
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
closes #1699
TODO: