feat(ops): Automatic fast ops creation #15527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it turns out that the |
aapoalas
force-pushed
the
feat/ops-simplified-fast-ops
branch
from
1beb3e8 to
9ab657d
Compare
aapoalas
changed the title
dsherret
pushed a commit
to dsherret/deno
that referenced
this pull request
Sep 22, 2022
hardfist
pushed a commit
to hardfist/deno
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
options.datato get access to theOpCtxstruct instead of using thereceiverobject (essentially thethisargument).This puts fast ops' context access on essentially the same path as "slow ops", ie. both use the
external_dataargument.I was hoping this would enable removing all or at least some of the
ExternalResourcestuff but that does not seem to be the case, though I do not understand why they're needed now and why they need to be kept out of the snapshot creation.There might be a very nasty crash hidden in this PR: Once when running the
deno_commonbenchmarks my whole computer froze...I expect I'll need help to polish this PR to a proper level where it can be merged. Especially the
ExternalResourcestuff is something that I'd love to remove one way or another but I'm not sure how.EDIT: As a test, I added a minor change with major effect to the fast ops macro: It's no longer opt in but instead is used for all sync ops if applicable. Also, I fixed the completely broken data extracting from the options bag. Build still passes, which is nice.