Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/webgpu): GPUDevice.features should be SetLike. #15853

Merged
merged 3 commits into from
Sep 20, 2022
Merged

fix(ext/webgpu): GPUDevice.features should be SetLike. #15853

merged 3 commits into from
Sep 20, 2022

Conversation

vicary
Copy link
Contributor

@vicary vicary commented Sep 10, 2022 •
edited
Loading

Fixes #15702.

vicary
vicary commented Sep 10, 2022
View reviewed changes
Copy link
Contributor Author

@vicary vicary left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vicary vicary mentioned this pull request Sep 14, 2022
Closed
@vicary vicary force-pushed the fix/gpudevice-features branch from 09fc5b7 to e0ab43d Compare September 18, 2022 04:46
crowlKats
crowlKats requested changes Sep 19, 2022
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typings in cli/dts/lib.deno_webgpu.d.ts need to be updated as well

@vicary
Copy link
Contributor Author

vicary commented Sep 19, 2022

Updated!

crowlKats
crowlKats approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@vicary
Copy link
Contributor Author

vicary commented Sep 19, 2022

Just to be safe I did a whole project grep, should I update these lines too?

deno/ext/webgpu/src/01_webgpu.js

Lines 746 to 747 in 1ebbe23

* @property {GPUFeatureName[]} features
* @property {object} limits

deno/ext/webgpu/src/01_webgpu.js

Lines 755 to 758 in 1ebbe23

/** @type {GPUFeatureName[]} */
features;
/** @type {object} */
limits;

@crowlKats
Copy link
Member

Oh yea that would be helpful

@vicary vicary force-pushed the fix/gpudevice-features branch from 1ebbe23 to 50ba5c8 Compare September 19, 2022 17:50
@vicary
Copy link
Contributor Author

vicary commented Sep 19, 2022

Rebased upstream along with the change.

@vicary
Copy link
Contributor Author

vicary commented Sep 19, 2022

Hm I don't quite understand the failing tests, how should I fix it?

@crowlKats
Copy link
Member

I took care of it, was just flaky CI

@crowlKats crowlKats merged commit 2929ec9 into denoland:main Sep 20, 2022
crowlKats added a commit to crowlKats/wgpu that referenced this pull request Sep 20, 2022
@crowlKats @vicary
Upstream denoland/deno#15853
7d4b6bf 
Co-authored-by: Vicary A <vicary@yahoo.com>
cwfitzgerald pushed a commit to gfx-rs/wgpu that referenced this pull request Sep 20, 2022
@crowlKats @vicary
Upstream denoland/deno#15853 (#3038)
03b989c 
Co-authored-by: Vicary A <vicary@yahoo.com>
@vicary vicary mentioned this pull request Sep 20, 2022
Closed
@vicary vicary deleted the fix/gpudevice-features branch September 21, 2022 19:51
dsherret pushed a commit to dsherret/deno that referenced this pull request Sep 22, 2022
@vicary @dsherret
fix(ext/webgpu): make GPUDevice.features SetLike (denoland#15853)
29c0951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[deno_webgpu] WebGPU GPUSupportedFeatures object doesn't include has method
2 participants
@vicary @crowlKats