Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ext/http): use String.prototype.trim() instead of regex #17722

Merged
merged 1 commit into from
Feb 10, 2023
Merged

refactor(ext/http): use String.prototype.trim() instead of regex #17722

merged 1 commit into from
Feb 10, 2023

Conversation

piscisaureus
Copy link
Member

No description provided.

@piscisaureus piscisaureus force-pushed the fix-regex branch 2 times, most recently from 9bde76c to 83c2dd4 Compare February 10, 2023 18:58
@piscisaureus piscisaureus changed the title fix(ext/http): remove inefficient regular expression refactor(ext/http): use String.prototype.trim instead of regex Feb 10, 2023
@piscisaureus piscisaureus changed the title refactor(ext/http): use String.prototype.trim instead of regex refactor(ext/http): use String.prototype.trim() instead of regex Feb 10, 2023
dsherret
dsherret approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piscisaureus piscisaureus enabled auto-merge (squash) February 10, 2023 19:27
@piscisaureus piscisaureus merged commit cf06a7c into denoland:main Feb 10, 2023
@piscisaureus piscisaureus deleted the fix-regex branch February 10, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piscisaureus @dsherret