feat: Deno.createHttpClient allowHost #19689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should also test that the header is sent, not just that it's exposed in the |
lucacasonato
reviewed
Jul 3, 2023
aapoalas
reviewed
Jul 4, 2023
| @@ -237,11 +237,11 @@ pub fn op_fetch<FP>( | |||
| where | |||
| FP: FetchPermissions + 'static, | |||
| { | |||
| let client = if let Some(rid) = client_rid { | |||
| let (client, allow_host) = if let Some(rid) = client_rid { | |||
There was a problem hiding this comment.
comment: This is the first time I see this sort of combination of let and if let Some(X) = Y. I am both in awe and appalled :D But, it makes sense after a while and was here before we got here so of course why not.
bartlomieju
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to allow using the host header in a fetch call.
Closes #16840
Ref #11017