Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): Creating a TestReporter trait #19786

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

skycoop
Copy link
Contributor

@skycoop skycoop commented Jul 10, 2023

This PR breaks the addition of the TestReporter trait and refactoring of PrettyTestReporter out of #19747. The goal is to enable the addition of test reporters, including machine readable output.

@skycoop skycoop enabled auto-merge (squash) July 10, 2023 16:26
@skycoop skycoop requested a review from bartlomieju July 10, 2023 16:26
@skycoop skycoop disabled auto-merge July 10, 2023 18:26
@skycoop skycoop enabled auto-merge (squash) July 10, 2023 18:26
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I thought we already had this trait at one point.

@skycoop skycoop merged commit 96efe3c into main Jul 10, 2023
@skycoop skycoop deleted the skycoop/test-reporter-trait branch July 10, 2023 22:12
@skycoop
Copy link
Contributor Author

skycoop commented Jul 10, 2023

LGTM. I thought we already had this trait at one point.

I think so as well given some of the comments on #8550, but seemed to have been removed since

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants