feat(node): add polyfill for node:test module #20002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Jul 31, 2023
dsherret
approved these changes
Aug 1, 2023
| async throw fail => node:test:135:10 | ||
| async skip fail => node:test:135:10 | ||
| async assertion fail => node:test:135:10 | ||
| reject fail => node:test:135:10 |
There was a problem hiding this comment.
Perhaps we should wildcard these line numbers?
There was a problem hiding this comment.
I'd rather not - they show a problem that the current implementation doesn't point to proper place - all point to a wrapper function in ext/node/polyfills/testing.ts module. I think I know how to fix it in the implementation of Deno.test but I want to do it in a follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides basic polyfill for "node:test" module. Currently only
top-level "test" function is polyfilled, all remaining functions from that module
throw not implemented errors.