Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unstable/lsp): support navigating to deno_modules folder #20030

Merged
merged 3 commits into from
Aug 2, 2023
Merged

feat(unstable/lsp): support navigating to deno_modules folder #20030

merged 3 commits into from
Aug 2, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 2, 2023

Closes #20015
Closes denoland/vscode_deno#850 (only for deno_modules, but I don't think this will be possible for the global cache)

@dsherret dsherret mentioned this pull request Aug 2, 2023
Closed
@dsherret dsherret marked this pull request as ready for review August 2, 2023 19:55
bartlomieju
bartlomieju approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice, great to have it landed before the release.

Nice test coverage 👍

@dsherret dsherret merged commit 480894e into denoland:main Aug 2, 2023
12 of 15 checks passed
@dsherret dsherret deleted the feat_lsp_support_deno_modules branch August 2, 2023 20:58
@nayeemrmn nayeemrmn mentioned this pull request Sep 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dsherret @bartlomieju