Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(test): lower base overhead to <1ms #20082

Closed
wants to merge 3 commits into from
Closed

perf(test): lower base overhead to <1ms #20082

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e04f91
perf(test): lower base overhead
bartlomieju Sep 11, 2023
73af5ec
try spinning event loop between tests
bartlomieju Sep 11, 2023
e8ec59d
lint
bartlomieju Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions cli/js/40_testing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ const ops = core.ops;
import { setExitHandler } from "ext:runtime/30_os.js";
import { Console } from "ext:deno_console/01_console.js";
import { serializePermissions } from "ext:runtime/10_permissions.js";
import { setTimeout } from "ext:deno_web/02_timers.js";
import { assert } from "ext:deno_web/00_infra.js";
const primordials = globalThis.__bootstrap.primordials;
const {
Expand Down Expand Up @@ -44,15 +43,18 @@ let hasSetOpSanitizerDelayMacrotask = false;
// will have an associated op. An additional `setTimeout` of 0 is needed
// before that, though, in order to give time for worker message ops to finish
// (since timeouts of 0 don't queue tasks in the timer queue immediately).
function opSanitizerDelay() {
async function opSanitizerDelay() {
if (!hasSetOpSanitizerDelayMacrotask) {
core.setMacrotaskCallback(handleOpSanitizerDelayMacrotask);
hasSetOpSanitizerDelayMacrotask = true;
}

// Spin the event loop for a little bit to let all async ops settle.
for (let i = 0; i < 100; i++) {
await core.opAsync("op_void_async_deferred");
}
return new Promise((resolve) => {
setTimeout(() => {
ArrayPrototypePush(opSanitizerDelayResolveQueue, resolve);
}, 1);
ArrayPrototypePush(opSanitizerDelayResolveQueue, resolve);
});
}

Expand Down