-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve async op santizer speed and accuracy #20501
Merged
lucacasonato
merged 9 commits into
denoland:main
from
lucacasonato:faster_async_op_sanitizer
Sep 16, 2023
Merged
perf: improve async op santizer speed and accuracy #20501
lucacasonato
merged 9 commits into
denoland:main
from
lucacasonato:faster_async_op_sanitizer
Sep 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test failures are legit - some are bad tests, but the worker related ones are real. Working on a fix. |
This commit improves async op sanitizer speed by only delaying metrics collection if there are `op_sleep` ops in the resource table. It performs this check and possible delay on every collection now, fixing an issue with parent test leaks into steps.
lucacasonato
force-pushed
the
faster_async_op_sanitizer
branch
from
September 15, 2023 12:03
176a5ed
to
8c617e0
Compare
bartlomieju
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no comments. Awesome improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves async op sanitizer speed by only delaying metrics
collection if there are
op_sleep
ops in the resource table. Thisresults in a speedup of around 30% for small CPU bound unit tests.
It performs this check and possible delay on every collection now,
fixing an issue with parent test leaks into steps. Fixes #20498
Before:
After: