Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize read and write ops #2259

Merged
merged 11 commits into from
May 3, 2019
Merged

Optimize read and write ops #2259

merged 11 commits into from
May 3, 2019

Conversation

ry
Copy link
Member

@ry ry commented May 1, 2019 •
edited
Loading

Essentially side step flatbuffers.

Benching deno -A tests/http_bench.ts

this branch:

~/src/deno> third_party/wrk/mac/wrk http://127.0.0.1:4500/
Running 10s test @ http://127.0.0.1:4500/
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   279.10us  479.38us   8.05ms   96.60%
    Req/Sec    22.82k     1.46k   26.34k    79.21%
  458621 requests in 10.10s, 22.31MB read
Requests/sec:  45403.95
Transfer/sec:      2.21MB

master:

~/src/deno> third_party/wrk/mac/wrk http://127.0.0.1:4500/
Running 10s test @ http://127.0.0.1:4500/
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   380.73us  545.44us   6.88ms   96.20%
    Req/Sec    16.09k     1.70k   18.80k    82.00%
  320396 requests in 10.01s, 15.58MB read
Requests/sec:  32017.73
Transfer/sec:      1.56MB

@ry ry mentioned this pull request May 1, 2019
Closed
@denoland denoland deleted a comment May 1, 2019
@ry ry force-pushed the minimal_dispatch2 branch from 04bfe59 to cb2f36d Compare May 1, 2019 07:28
@ry ry requested a review from piscisaureus May 1, 2019 19:19
@ry ry force-pushed the minimal_dispatch2 branch 2 times, most recently from fd491af to d8f7f58 Compare May 2, 2019 04:55
@ry ry force-pushed the minimal_dispatch2 branch from d8f7f58 to 4ec6dfa Compare May 2, 2019 20:19
piscisaureus
piscisaureus reviewed May 2, 2019
View reviewed changes
cli/dispatch_minimal.rs Outdated Show resolved Hide resolved
cli/dispatch_minimal.rs Outdated Show resolved Hide resolved
cli/dispatch_minimal.rs Outdated Show resolved Hide resolved
cli/dispatch_minimal.rs Outdated Show resolved Hide resolved
cli/ops.rs Outdated Show resolved Hide resolved
js/dispatch_minimal.ts Outdated Show resolved Hide resolved
cli/dispatch_minimal.rs Show resolved Hide resolved
js/files.ts Show resolved Hide resolved
js/files.ts Show resolved Hide resolved
cli/dispatch_minimal.rs Show resolved Hide resolved
piscisaureus
piscisaureus approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 00ac871 into denoland:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ry @piscisaureus