Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make accept use minimal_dispatch #2278

Closed
wants to merge 1 commit into from

Conversation

ry
Copy link
Member

@ry ry commented May 3, 2019

this branch

~/src/deno> ./third_party/wrk/mac/wrk -d 20 http://localhost:4500/
Running 20s test @ http://localhost:4500/
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   263.62us  450.37us   8.45ms   96.34%
    Req/Sec    23.98k     1.81k   28.68k    81.34%
  958979 requests in 20.10s, 46.64MB read
Requests/sec:  47706.68
Transfer/sec:      2.32MB

master

~/src/deno> ./third_party/wrk/mac/wrk -d 20 http://localhost:4500/
Running 20s test @ http://localhost:4500/
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   275.87us  490.25us   8.07ms   96.30%
    Req/Sec    23.20k     2.06k   27.56k    72.14%
  928345 requests in 20.10s, 45.15MB read
Requests/sec:  46182.19
Transfer/sec:      2.25MB

Here are the benchmark results from travis:

  "req_per_sec": {
    "node": 31492, 
    "deno_core_single": 76514, 
    "hyper": 96890, 
    "deno_core_multi": 84595, 
    "deno_net_http": 19265, 
    "deno": 70378, 
    "node_tcp": 81977
  }, 
  "max_latency": {
    "node": 11.74, 
    "deno_core_single": 8.22, 
    "hyper": 5.12, 
    "deno_core_multi": 10.15, 
    "deno_net_http": 14.99, 
    "deno": 13.6, 
    "node_tcp": 12.1
  }, 

@ry ry mentioned this pull request May 3, 2019
@ry ry requested a review from piscisaureus May 3, 2019 14:15
@piscisaureus
Copy link
Member

I don't see a significant difference in performance, plus this is a regression in the sense that error information is lost.
So I'm -1 for now.

Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@ry
Copy link
Member Author

ry commented May 3, 2019

@piscisaureus This takes flatbuffers completely out of the loop for tests/http_bench.ts which allows us to focus on the remaining bottlenecks. Without thinking thru the logic of the server is difficult.

The error codes will be dealt with eventually - I think the regression is worth it

@ry
Copy link
Member Author

ry commented May 3, 2019

nevermind. the accept isn't in the hot loop for test/http_bench.ts I will put this off until we have a more established minimal dispatch

@ry ry closed this May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants