fix(ext/node): Add fs.lutimes / fs.lutimesSync
#23172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The node_compat test is failing on the windows runner due to a permission denied error when making (or maybe removing?) a temp file. I don't have a windows machine to debug this on, but it's odd that it only fails on the |
nathanwhit
force-pushed
the
node-fs-lutimes
branch
from
7fc13bc
to
82bae74
Compare
nathanwhit
force-pushed
the
node-fs-lutimes
branch
from
f9a79f3
to
c64ac28
Compare
|
CI issue has been fixed, so this is now ready for review |
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
Part of denoland#18218 - Adds `fs.lutimes` and `fs.lutimesSync` to our node polyfills. To do this I added methods to the `FileSystem` trait + ops to expose the functionality to JS. - Exports `fs._toUnixTimestamp`. Node exposes an internal util `toUnixTimestamp` from the fs module to be used by unit tests (so we need it for the unit test to pass unmodified). It's weird because it's only supposed to be used internally but it's still publicly accessible - Matches up error handling and timestamp handling for fs.futimes and fs.utimes with node - Enables the node_compat utimes test - this exercises futimes, lutimes, and utimes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #18218
fs.lutimesandfs.lutimesSyncto our node polyfills. To do this I added methods to theFileSystemtrait + ops to expose the functionality to JS.fs._toUnixTimestamp. Node exposes an internal utiltoUnixTimestampfrom the fs module to be used by unit tests (so we need it for the unit test to pass unmodified). It's weird because it's only supposed to be used internally but it's still publicly accessible