Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/net): validate port in Deno.{connect,serve,listen} #24399

Merged
merged 13 commits into from
Aug 20, 2024

Conversation

sbmsr
Copy link
Contributor

@sbmsr sbmsr commented Jul 2, 2024

Closes #21947
Closes #21896

@sbmsr sbmsr force-pushed the fix-21896-validate-port-on-serve-2 branch from dd9e67b to 4bdd01d Compare July 2, 2024 18:15
@sbmsr sbmsr marked this pull request as ready for review July 2, 2024 18:15
@sbmsr sbmsr changed the title fix 21896 validate port on serve 2 fix(ext/net): validate port in Deno.{connect,serve,listen} Jul 2, 2024
@sbmsr sbmsr force-pushed the fix-21896-validate-port-on-serve-2 branch from c95faec to 0a4f523 Compare July 5, 2024 15:47
@bartlomieju bartlomieju added this to the 1.46 milestone Jul 18, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret enabled auto-merge (squash) August 20, 2024 20:54
@dsherret dsherret merged commit a3a54bc into denoland:main Aug 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno.listen() does not properly check the port parameter
5 participants