feat: codesign for deno compile binaries #24604
Conversation
littledivy
changed the title
| @@ -129,66 +133,94 @@ pub fn load_npm_vfs(root_dir_path: PathBuf) -> Result<FileBackedVfs, AnyError> { | |||
| root_path: root_dir_path, | |||
| start_file_offset: trailer.npm_files_pos, | |||
| }; | |||
| Ok(FileBackedVfs::new(file, fs_root)) | |||
| Ok(FileBackedVfs::new(data.to_vec(), fs_root)) | |||
There was a problem hiding this comment.
For future: FileBackedVfs can be made a zero-copy view on data because sui returns a slice :)
|
Let's aim to land this one in v1.46. Is there anything blocking the Windows CI passing? |
|
Yup, v1.46 is reasonable. I rewrote sui and removed dependency on LIEF. Currently blocked on: denoland/sui#5 |
|
Moved Ready for review |
There was a problem hiding this comment.
LGTM!
The only real risk I see is staying up to date with apple's changes to mach-o (they've been known to add new load commands in updates). But since we're just patching offsets in LCs, it shouldn't be too hard to fix if that happens. I think it's probably not a big deal
Signed-off-by: Divy Srivastava <dj.srivastava23@gmail.com>
|
Hurray!!! |
Uses sui to inject metadata as a custom section in the denort binary.
Metadata is stored as a Mach-O segment on macOS and PE
RT_RCDATAresource on Windows.Fixes #11154
Fixes #17753