feat(node): support username and _password in .npmrc file
#24793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
added
ci-draft
I think we should do it in this PR |
bartlomieju
reviewed
Jul 30, 2024
|
npm throws when |
bartlomieju
approved these changes
Aug 13, 2024
Comment on lines
+32
to
+33
| if (username.is_some() && password.is_none()) | ||
| || (username.is_none() && password.is_some()) |
There was a problem hiding this comment.
Nitpick, but you can probably compat this and the next conditional by using a match like so:
match (username, password) {
(Some(username), Some(password)) => {...},
(Some(_) , None_ => {...},
(None, Some(_) => {...},
_ => {}
}There was a problem hiding this comment.
I'll revisit this once when we add the certfile and keyfile fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23950