fix(streams): reject string in ReadableStream.from type
#25116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petamoriken
changed the title
string in ReadableStream.fromstring in ReadableStream.from type
petamoriken
force-pushed
the
fix/reject-string-in-readable-stream-from
branch
from
e4b4ac9 to
5867a8c
Compare
|
relanded: #26882 |
petamoriken
commented
Nov 15, 2024
Comment on lines
-63
to
+64
| interface ReadableStreamGenericReader<T> { | ||
| readonly closed: Promise<void>; | ||
| interface ReadableStreamGenericReader { | ||
| readonly closed: Promise<undefined>; |
There was a problem hiding this comment.
I fixed differences with lib.dom.d.ts
bartlomieju
pushed a commit
that referenced
this pull request
Nov 28, 2024
WebIDL `async iterable<T>` type rejects `string` Ref whatwg/webidl#1397, #24623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebIDL
async iterable<T>type rejectsstringRef whatwg/webidl#1397, #24623