Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch: make response.body async iterable #2563

Merged
merged 1 commit into from
Jun 22, 2019

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 22, 2019

This PR makes response.body of fetch async iterable.

fixes #2520

@kt3k kt3k force-pushed the feature/body-async-iterator branch from bce6c78 to 11a2161 Compare June 22, 2019 09:07
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

total += chunk.length;
}

assertEquals(total, Number(headers.get("Content-Length")));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ry ry merged commit 988bcbb into denoland:master Jun 22, 2019
@kt3k kt3k deleted the feature/body-async-iterator branch June 22, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async iteration for fetch response body
2 participants