refactor(ext/crypto): use concrete error types #26167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
catuhana
reviewed
Oct 12, 2024
| General(#[from] SharedError), | ||
| #[error(transparent)] | ||
| Pkcs1(#[from] rsa::pkcs1::Error), | ||
| #[error("Decryption failed")] |
There was a problem hiding this comment.
All other error strings start as a lowercase. Is that supposed to be lowercase too?
There was a problem hiding this comment.
I am planning to clean up the messages a bit on a follow-up; for now i just moved the strings, so this is like it was before. I agree this should be more consistent, but wont do that in this PR
Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>
# Conflicts: # ext/crypto/lib.rs # runtime/errors.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.