Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ext/websocket): use concrete error type #26226

Merged
merged 13 commits into from
Oct 18, 2024

Conversation

crowlKats
Copy link
Member

No description provided.

pub fn get_or_try_init(&self) -> Result<Option<RootCertStore>, AnyError> {
pub fn get_or_try_init(
&self,
) -> Result<Option<RootCertStore>, deno_core::error::AnyError> {
Copy link
Member

@bartlomieju bartlomieju Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use concrete error type here and other methods?

Copy link
Member Author

@crowlKats crowlKats Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because RootCertStoreProvider trait still returns anyerror as well; since it touches multiple parts, i want to keep that for after we do the exts, so when updating runtime & CLI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.

@crowlKats crowlKats enabled auto-merge (squash) October 18, 2024 19:17
@crowlKats crowlKats merged commit d047cab into denoland:main Oct 18, 2024
17 checks passed
@crowlKats crowlKats deleted the websocket-error-rework branch October 18, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants