WIP async stack traces ...

[ry]

cc @Nayeem-Rahman

> ./tools/build.py libdeno_test && ./target/debug/libdeno_test --gtest_filter=LibDenoTest.AsyncException
ninja: Entering directory `/Users/rld/src/deno/target/debug'
[2/2] LINK ./libdeno_test
Note: Google Test filter = LibDenoTest.AsyncException
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from LibDenoTest
[ RUN      ] LibDenoTest.AsyncException
Error
    at /Users/rld/src/deno/core/libdeno/libdeno_test.js:260:21
    at async /Users/rld/src/deno/core/libdeno/libdeno_test.js:259:5
deno_last_exception (null)
deno_last_exception {"message":"Uncaught Error","sourceLine":"","lineNumber":0,"startPosition":-1,"endPosition":-1,"errorLevel":8,"startColumn":-1,"endColumn":-1,"isSharedCrossOrigin":true,"isOpaque":false,"frames":[{"line":260,"column":21,"scriptName":"/Users/rld/src/deno/core/libdeno/libdeno_test.js","isEval":false,"isConstructor":false,"isWasm":false}]}
[       OK ] LibDenoTest.AsyncException (80 ms)
[----------] 1 test from LibDenoTest (80 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (80 ms total)
[  PASSED  ] 1 test.

Other places to look

• isolate_->SetPromiseRejectCallback()

  deno/core/libdeno/binding.cc

  Line 562 in deec1b9

  isolate_->SetPromiseRejectCallback(deno::PromiseRejectCallback);

[nayeemrmn]

I think --async-stack-traces is on by default. All it's specified to do is enrich error.stack: https://v8.dev/docs/stack-trace-api#async-stack-traces (says it's off by default but that's changed I guess).

[ry]

It doesn’t seem to have an effect - I was just trying it

[kitsonk]

I think they have to be collected via other APIs 😢 see: nodejs/node#11865 (comment)

[ry]

stale