Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node/fs): support recursive option in readdir #27179

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

marvinhagemeister
Copy link
Contributor

We didn't support the recursive option of fs.readdir()/fs.readdirSync().

Fixes #27175

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix

@marvinhagemeister marvinhagemeister merged commit 2fbc5fe into main Dec 3, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the node-readdir-recursive branch December 3, 2024 09:28
bartlomieju pushed a commit that referenced this pull request Dec 5, 2024
We didn't support the `recursive` option of
`fs.readdir()/fs.readdirSync()`.

Fixes #27175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno fs.readdir(rootDir, { recursive: true }) does not recurse
2 participants