-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(task): --recursive
option not working
#27183
Conversation
66b386e
to
ffcea49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still doesn't seem to work correctly, I have a repo like this:
- client/
- deno.json
- main.ts
- server/
- deno.json
- main.ts
- deno.json
Both client and server have a single dev
task that runs deno run ./main.ts
in respective packages. The root deno.json
is:
{
"workspace": [
"./client", "./server"
]
}
then running:
../deno/target/debug/deno task --recursive dev
No matching task or script 'dev' found in selected packages.
or
../deno/target/debug/deno task --recursive --filter "*" dev
No matching task or script 'dev' found in selected packages.
./deno/target/debug/deno task --recursive --filter "client" dev
No matching task or script 'dev' found in selected packages.
00bc93b
to
ecba2b2
Compare
Good point, missed that case when the |
@marvinhagemeister so now this works, but I think there's still some problems. This looks okay, but maybe in a follow up we could improve the output to show tasks from workspace members?
This works fine:
This seems to ignore the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that it now works correctly. LGTM
We didn't handle the `--recursive` option properly in `deno task`. This PR addresses that. Fixes #27174
We didn't handle the
--recursive
option properly indeno task
. This PR addresses that.Fixes #27174