Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(task): only pass args to root task #27213

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

marvinhagemeister
Copy link
Contributor

When we run deno task with args like deno task foo arg the argument should only be passed to the root task, not to its dependencies.

Fixes #27206

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit d5b63bb into main Dec 3, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the task-pass-args branch December 3, 2024 15:35
bartlomieju pushed a commit that referenced this pull request Dec 5, 2024
When we run `deno task` with args like `deno task foo arg` the argument
should only be passed to the root task, not to its dependencies.

Fixes #27206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno task passed rest arguments to dependencies unintentionally
2 participants