Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace the @deno-types with @ts-types #27310

Merged
merged 8 commits into from
Dec 10, 2024
Merged

fix: replace the @deno-types with @ts-types #27310

merged 8 commits into from
Dec 10, 2024
+24 −26

Conversation

MohammadSu1
Copy link
Contributor

This PR closes #27309

@kt3k
Copy link
Member

kt3k commented Dec 10, 2024

Thanks for the PR!

Can you also fix the test case lsp::diagnostics::tests::duplicate_diagnostics_for_duplicate_imports?

(Note: You can run only that case locally with the command cargo test lsp::diagnostics::tests::duplicate_diagnostics_for_duplicate_imports

@MohammadSu1
Copy link
Contributor Author

Yes, I am currently working on this.

kt3k
kt3k approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@nayeemrmn @dsherret Can you take another look?

dsherret
dsherret approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@dsherret dsherret merged commit 59dd5d2 into denoland:main Dec 10, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request Dec 11, 2024
@MohammadSu1 @bartlomieju
fix: replace the @deno-types with @ts-types (#27310)
e24d953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSP actions use @deno-types instead pf @ts-types
3 participants
@MohammadSu1 @kt3k @dsherret