Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lockfile): include dependencies listed in external import map in lockfile #27337

Merged
merged 4 commits into from
Dec 13, 2024
Merged

fix(lockfile): include dependencies listed in external import map in lockfile #27337

merged 4 commits into from
Dec 13, 2024

Conversation

nathanwhit
Copy link
Member

No description provided.

@nathanwhit nathanwhit requested a review from dsherret December 11, 2024 23:23
nathanwhit
nathanwhit commented Dec 11, 2024
View reviewed changes
cli/args/lockfile.rs Outdated Show resolved Hide resolved
@nathanwhit nathanwhit mentioned this pull request Dec 12, 2024
Merged
@nathanwhit nathanwhit force-pushed the include-import-map-lockfile branch from b725e6e to 4603997 Compare December 12, 2024 23:29
dsherret
dsherret approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see comment.

cli/args/mod.rs Show resolved Hide resolved
@nathanwhit nathanwhit merged commit 3946956 into denoland:main Dec 13, 2024
17 checks passed
@nathanwhit nathanwhit deleted the include-import-map-lockfile branch December 13, 2024 18:19
nathanwhit added a commit that referenced this pull request Dec 13, 2024
@nathanwhit
fix(outdated): support updating dependencies in external import maps (#…
9d315f2 
…27339)

Fixes #27331.

The support for it was already in `outdated`, but forgot to wire up the
updating part

Needs #27337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanwhit @dsherret