Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): sql and component file formatting #27350

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(lsp): sql and component file formatting #27350

merged 1 commit into from
Dec 13, 2024

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Dec 13, 2024 •
edited
Loading

Server-side changes for #27173 (comment). Alongside denoland/vscode_deno#1223.

@nayeemrmn nayeemrmn mentioned this pull request Dec 13, 2024
Merged
bartlomieju
bartlomieju approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, isn't this technically a fix since we missed adding support when landing these formatter improvements?

@lucacasonato lucacasonato changed the title feat(lsp): sql and component file formatting fix(lsp): sql and component file formatting Dec 13, 2024
@nayeemrmn nayeemrmn merged commit 32b57f7 into denoland:main Dec 13, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-fmt-sql-component branch December 13, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nayeemrmn @bartlomieju