fix(ext/node): do not exit worker thread when there is pending async op #27378
+49
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the premature exit of worker threads when there are still remaining pending ops.
This PR reuses the idea of #22647 (unref'ing
op_worker_recv_messagein worker threads if closeOnIdle specified) and usesweb_worker.has_message_event_listenercheck in the opposite way as #22944. (Now we continue the worker whenhas_message_event_listeneris true instead of stopping it whenhas_message_event_listeneris false.closes #23061
closes #26154
This change seems fixing the pino logger's file output behavior (#26154 )