Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(task): properly handle task name wildcards with --recursive #27396

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Dec 17, 2024

This commit fixes deno task by checking if the provided
task name actually has a wildcard char ("*").

Previously, if the "--recursive" flag was passed, the task name
was treated as a regex, which lead to a situation where exact task
name resulted in a regex that matched all tasks with the specific prefix.

This commit fixes it, by checking if the provided task name, is an exact
name, or is it a wildcard match.

Closes #27370
Closes #27401
Closes #27408

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix. I like the idea of checking for * 👍

@bartlomieju bartlomieju merged commit 14e4064 into denoland:main Dec 18, 2024
17 checks passed
@bartlomieju bartlomieju deleted the deno_task_infinite_recursion branch December 18, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants