Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/fetch): retry some http/2 errors #27417

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

seanmonstar
Copy link
Contributor

This brings some of the HTTP/2 retry behavior from reqwest to ext/fetch. It will retry very specific HTTP/2 errors once, if the body is able to be used again.

cc #27332

@seanmonstar
Copy link
Contributor Author

I can't remember, is that CI job saying each PR should have the Cargo.lock completely updated?

@lucacasonato
Copy link
Member

I don't know what is up with that. @bartlomieju any ideas?

@nathanwhit
Copy link
Member

I believe it just means that running cargo clippy resulted in the lockfile being updated (we run with --locked in CI, so it fails if the lockfile would change). So you should just need to run that locally and commit the updated lockfile.

@seanmonstar seanmonstar force-pushed the fetch-min-retry branch 4 times, most recently from ecadba0 to 28e31cf Compare December 18, 2024 19:35
@bartlomieju bartlomieju merged commit b1c685f into denoland:main Dec 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants